Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Add aria-labelledBy and aria-label to slider body #1070

Open
MarkoOleksiyenko opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1073
Open

[Slider] Add aria-labelledBy and aria-label to slider body #1070

MarkoOleksiyenko opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1073
Labels
enhancement New feature or request widget: slider

Comments

@MarkoOleksiyenko
Copy link
Contributor

Add an option to add the aria-labelledBy for the handles
Add the option to add aria-label, aria-labelledBy to the component itself
@MarkoOleksiyenko
Copy link
Contributor Author

Component itself should not have the aria values, the screen readers only read the actionable handle values.

Corrections to be applied for the existent component:
aria-label -> should not contain value as SR will read the aria-valuenow
aria-valuetext -> doesn't need the non-sorted index of the handle

Remove the handle from the aria-label as it only can concern handles.

@MarkoOleksiyenko MarkoOleksiyenko linked a pull request Dec 26, 2024 that will close this issue
fix(slider): Set up aria values for handles #1073
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request widget: slider
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slider): Set up aria values for handles MarkoOleksiyenko/AgnosUI
1 participant
@MarkoOleksiyenko