Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): Set up aria values for handles #1073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarkoOleksiyenko
Copy link
Contributor

@MarkoOleksiyenko MarkoOleksiyenko commented Dec 26, 2024

No description provided.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (9c85fb9) to head (b84de24).

Files with missing lines Patch % Lines
core/src/components/slider/slider.ts 85.71% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9c85fb9) and HEAD (b84de24). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9c85fb9) HEAD (b84de24)
e2e 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
- Coverage   91.30%   84.28%   -7.02%     
==========================================
  Files          99       50      -49     
  Lines        2690     2043     -647     
  Branches      444      375      -69     
==========================================
- Hits         2456     1722     -734     
- Misses        155      229      +74     
- Partials       79       92      +13     
Flag Coverage Δ
e2e ?
unit 84.28% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarkoOleksiyenko MarkoOleksiyenko force-pushed the slider-a11y branch 4 times, most recently from 156ee0f to c8a3067 Compare December 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] Add aria-labelledBy and aria-label to slider body
1 participant