Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError exception being thrown in thinkdsp.py call to numpy #92

Open
sizzzzlerz opened this issue Aug 2, 2023 · 2 comments
Open

Comments

@sizzzzlerz
Copy link

I am running the notebooks using Python 3.11 and the latest numpy version 1.25.0.

Line 599 in thinkdsp.py is causing an AttributeError exception to be thrown in spectrogram.plot

array = np.zeros(size, dtype=np.float)

The exception is complaining that np.float has been deprecated from numpy and that just 'float' alone should be used. I found this in other places in the file but this was the first one that was invoked. To fix this, I edited thinkdsp.py to make the changes. Once that was done, the entire notebook ran to completion.

@AllenDowney
Copy link
Owner

Should be fixed now. Thanks for letting me know!

@AllenDowney
Copy link
Owner

And now I have a github workflow to run the tests periodically, so things like this should not sneak up on me again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants