Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of thinkdsp #90

Open
WuodOdhis opened this issue Dec 12, 2022 · 7 comments
Open

Installation of thinkdsp #90

WuodOdhis opened this issue Dec 12, 2022 · 7 comments

Comments

@WuodOdhis
Copy link

I am writing to express my disappointment and frustration with trying to install thinkdsp on my system. I have followed the instructions on the GitHub page, but I am still unable to get thinkdsp working. I have tried troubleshooting the issue on my own, but I am unable to resolve it.

I am very disappointed in the difficulty I have had trying to install thinkdsp, and I am asking for your help in resolving this issue. I would appreciate if someone from your team could provide assistance or offer guidance on how to successfully install thinkdsp.

Thank you for your attention to this matter. I look forward to hearing from you and receiving help with this issue.

@AllenDowney
Copy link
Owner

I'm sorry to hear that this has been frustrating. Are you following the instructions here?

https://allendowney.github.io/ThinkDSP/

If so, what have you tried and what went wrong?

Also, please consider running the notebooks on Colab (see the links on the page linked above). That way you don't have to install anything.

@WuodOdhis
Copy link
Author

WuodOdhis commented Dec 13, 2022 via email

@WuodOdhis
Copy link
Author

WuodOdhis commented Dec 13, 2022 via email

@AllenDowney
Copy link
Owner

I understand. A key thing to understand is that thinkdsp.py is not a package you have to install; it is just a module -- that is, a file that contain Python code.

So you have to download it and make sure it is in a place where Python finds it. The easiest way to do that is to run the notebook and let it download thinkdsp.py, which it will do if it does not find the file already.

Which notebook are you running and where does it fail?

@WuodOdhis
Copy link
Author

WuodOdhis commented Dec 14, 2022 via email

@AllenDowney
Copy link
Owner

Don't install thinkx.

When you run the notebook, it should download and then import thinkdsp.py.

Does that work? If not, what happens?

@karelkedl
Copy link

I had similar issues with "installing" this module. But I donť use jupyter notebooks. I installed it with pip install thinkx, but but thinkdsp won't import due to: ImportError: cannot import name 'gcd' from 'fractions'. I found out that fractions.gcd(a, b) has been moved to math.gcd(a, b) in Python 3.9 in this link. So i replaced fractions on line 24 with from math import gcd. And it is running. I still got warning about Wave.make_audio() but it is not an issue form me.
Thank you for this module and for the book!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants