Downloader stops at 3900/

[ThunderousLeft]

No error produced - the downloader simply stopped downloading when it hit 3900/4600+ files, then stopped downloading when it hit 1252/1975 files, and consistently doesnt grab those last 700 downloads.

I was hoping to get your help to understand what is going on here

[ThunderousLeft]

[DavidArchibald]

The problem is this snippet:
https://github.com/AlexCSDev/UniversalDownloaderPlatform/blob/8eec8693944f5db4eb36e265f102dfe0889600e0/UniversalDownloaderPlatform.Engine/DownloadManager.cs#L91-L104

When a DownloadException happens OnFileDownloaded is still called (with a flag saying it failed) but any other error doesn't call OnFileDownloaded which is used for the counting. It seems you have roughly 700 errors which explains the undercounting.

[RisaDev]

That shouldn't be the case because any error other than DownloadException is not being handled anywhere and supposed to crash the application from what I can see.

[DavidArchibald]

Yeah I forgot that handling other errors was something I added in a fork so that solved it for me in that case.

The undercounting is still going to apply here though:
https://github.com/AlexCSDev/UniversalDownloaderPlatform/blob/8eec8693944f5db4eb36e265f102dfe0889600e0/UniversalDownloaderPlatform.Engine/DownloadManager.cs#L56-L66

It returns (ending the task) when it's not a valid url or it's a blacklisted URL without calling OnFileDownloaded either which means it never reaches the same event I was referring to last time:

PatreonDownloader/PatreonDownloader.App/Program.cs

Lines 210 to 217 in d201c14

	private static void UniversalDownloaderOnFileDownloaded(object sender, FileDownloadedEventArgs e)
	{
	_filesDownloaded++;
	if (e.Success)
	_logger.Info($"Downloaded {_filesDownloaded}/{e.TotalFiles}: {e.Url}");
	else
	_logger.Error($"Failed to download {e.Url}: {e.ErrorMessage}");
	}