SSH Server - not working proprely

[Geforcex250]

Hi,

First, well done for this project that I really enjoy and all the work you've spent on it !
(Especially by reimplementing an SSH server from a RFC, I imaging)

Before editing this ticket i've took extra precaution in order to test if the problem came from my environement and then trying to isolate the problem.

GitCandy is running on my Windows 10 machine, where i've disable Microsoft's built-in SSH server on port 22 by checking if where I was pointing to was displaying SSH-2.0-FxSsh. All paths are good including the one for git core.

Clones were either done on Ubuntu Bash and Git Bash, SSH keys were proprely generated and then added throught the admin interface of Git Candy.

For some reasons git clones were working proprely throught http but not with ssh, in the settings i've also changed multiple times SSH's port. Then everytime took the generated SSH connection string generated by the web interface in order to do the clones.

git clone git@localhost:git/test.git

Clonage dans 'test'...
Connection to localhost closed by remote host.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

As you see the connection does not get rejected for public key reasons. Digging in the code and adding extra debug lines, the connection gets rejected on service name == ssh-connection && method == none

05/15/2018 13:41:56.715 +01:00 Info, It is found 0 DLLs for resloving addion:
05/15/2018 13:41:57.606 +01:00 Info, Schedule runner 1 RealTime started
05/15/2018 13:41:57.618 +01:00 Info, Schedule runner 2 RealTime started
05/15/2018 13:41:57.678 +01:00 Info, Schedule runner 3 LongRunning started
05/15/2018 13:41:57.680 +01:00 Info, Schedule runner 4 LongRunning started
05/15/2018 13:41:57.684 +01:00 Info, Schedule runner 5 LongRunning started
05/15/2018 13:41:57.691 +01:00 Info, Schedule runner 6 LongRunning started
05/15/2018 13:41:57.697 +01:00 Info, Schedule runner 7 LongRunning started
05/15/2018 13:41:57.701 +01:00 Info, Schedule runner 8 LongRunning started
05/15/2018 13:41:57.883 +01:00 Info, SSH server started.
05/15/2018 13:41:57.883 +01:00 Info, GitCandy Started.
05/15/2018 13:41:58.316 +01:00 Warning, 404, GET, http://localhost:11422/favicon.ico
05/15/2018 13:41:58.643 +01:00 Info, Job GitCandy.Schedules.SingleJob executing on runner 6
05/15/2018 13:41:58.646 +01:00 Info, Job GitCandy.Schedules.SingleJob executed on runner 6, elapsed 00:00:00.0772052
05/15/2018 13:41:58.646 +01:00 Info, Job GitCandy.Schedules.LogJob executing on runner 4
05/15/2018 13:41:58.646 +01:00 Info, Job GitCandy.Schedules.LogJob executed on runner 4, elapsed 00:00:00.0777065
05/15/2018 13:41:58.896 +01:00 Info, Job GitCandy.Schedules.SingleJob executing on runner 8
05/15/2018 13:41:58.916 +01:00 Info, Job GitCandy.Schedules.SingleJob executed on runner 8, elapsed 00:00:00.0200593>> 05/15/2018 14:42:54.262 +01:00 Info, SERVICE NAME : ssh-connection -> METHOD NAME none -> MESSAGE TYPE : 50 -> USER NAME : git
05/15/2018 14:42:54.262 +01:00 Info, Sending failure message !
05/15/2018 14:42:54.263 +01:00 Info, SERVICE NAME : ssh-connection -> METHOD NAME publickey -> MESSAGE TYPE : 50 -> USER NAME : git
05/15/2018 14:42:54.266 +01:00 Info, SERVICE NAME : ssh-connection -> METHOD NAME publickey -> MESSAGE TYPE : 50 -> USER NAME : git

If you need extra informations please do not hesitate,
Thank you in advance,
Best regards

[Geforcex250]

I've pushed a fix on pull request #26