Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings issues #56

Open
wclr opened this issue Nov 19, 2018 · 2 comments
Open

Typings issues #56

wclr opened this issue Nov 19, 2018 · 2 comments

Comments

@wclr
Copy link

wclr commented Nov 19, 2018

You are writing with TS, and still typing seems to be not good, even @types/dockernode feel to have more proper typings.

Even your new Docker(/*opts: not typed*/) constructor has no typings for options, and results are typed not correctly:

image

It is not a critique, just want to draw your attention to typings issues.

@AgustinCB
Copy link
Owner

You're right. When I did this project, I was just starting with Typescript and missed a lot of things. I'd like to fix this, but I can't promise an ETA because I have other projects on the go.

That being said, contributions are welcomed.

@MartinMuzatko
Copy link

MartinMuzatko commented Jan 11, 2021

I'm also here in the search for proper types.
It should be easy though. you could just add @types/dockerode as a dependency and just re-use them.

Types are somewhat up to date: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/dockerode/index.d.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants