-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typings issues #56
Comments
You're right. When I did this project, I was just starting with Typescript and missed a lot of things. I'd like to fix this, but I can't promise an ETA because I have other projects on the go. That being said, contributions are welcomed. |
I'm also here in the search for proper types. Types are somewhat up to date: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/dockerode/index.d.ts |
You are writing with TS, and still typing seems to be not good, even
@types/dockernode
feel to have more proper typings.Even your
new Docker(/*opts: not typed*/)
constructor has no typings for options, and results are typed not correctly:It is not a critique, just want to draw your attention to typings issues.
The text was updated successfully, but these errors were encountered: