-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing of vendor-specific extended sentences that are not included in the SentenceType
fails.
#90
Comments
There's definitely a place for improvement here. It makes sense to keep our current validation process - if we don't have a parser for the sentences - return an error, however, we could improve the vendor specific sentences although not sure what you envision for it. PGRMZ is the only Vendor specific sentences and I think it's a good time to discuss how we should handle them |
For example, if the talker is NmeaSentence {
talker_id: "P",
message_id: SentenceType::VendorExtension("ABC"),
data: "abcdefg",
checksum: hh,
} I would like to make sure that |
Ok, so my current line of thought is to allow a callback for parsing unknown sentences, which will be great to the user as they will add the vendor-specific sentences instead of us.
|
Regardless of the sentence type, if it is correct as NMEA0183, one would expect it to be parsed using
nmea::parse_nmea_sentence
, but parsing fails if it is not included inSentenceType
.I don't have any ideas about what to do with the existing
PGRMZ
, but would it be possible to add an enumerator likeVendorExtension(&str)
to theSentenceType
to handle it?The text was updated successfully, but these errors were encountered: