-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll Group (Panning) #106
Comments
We currently don't support ScrollableGroup in the plugin, though I would like to add support if the APIs are there to support it (I think they are now). I'll check if we can make a quick update to turn that into a warning and preserve the child content as an immediate fix for the impending next version, and look into proper support for the following version (which should follow fairly quickly). |
Ok. I've looked into this, but unfortunately it looks like XD's API for ScrollableGroup is incomplete in that it does not provide a way to access the dimensions of the scrolling content. For example, for a vertically scrolling list, I'd expect a property like For now I have added a warning for scroll groups. Time permitting, I may add the iterative bounds calculation so we don't have to wait on Adobe to add this value. If that works out, I may be able to sneak in horizontal & vertical scrolling for the next version, but likely not panning (which requires a different Flutter output). |
Alright, I worked around the issues above by iteratively calculating the merged bounds, and then manually adjusting child positions based on the scroll offset (XD treats scrollable content as content that has moved, not as content that has been scrolled). Horizontal and vertical scrolling now appear to be working well and will be in the next release. Panning should land in the following version. |
That's great news Grant
Thank you very much, will be trying it out today. It's such an
important feature!
Regards
Paul
…-------- Original Message --------
SUBJECT:
Re: [AdobeXD/xd-to-flutter-plugin] Scroll Group (#106)
DATE:
2021-04-18 18:46
FROM:
Grant Skinner ***@***.***>
TO:
AdobeXD/xd-to-flutter-plugin
***@***.***>
Alright, I worked around the issues above by iteratively calculating the
merged bounds, and then manually adjusting child positions based on the
scroll offset (XD treats scrollable content as content that has moved,
not as content that has been scrolled).
Horizontal and vertical scrolling now appear to be working well and will
be in the next release. Panning should land in the following version.
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [1], or unsubscribe [2].
Links:
------
[1]
#106 (comment)
[2]
https://github.com/notifications/unsubscribe-auth/ANX5WP2IXW2VHRI5QISAJR3TJMEHRANCNFSM42SJRN5Q
|
Hi Grant Seems that your fix is working! Thank you! |
Just to confirm - are you testing the plugin built from source code? This feature isn't in the public plugin quite yet. |
Horizontal and vertical scroll groups shipped in v2.0.0, but I'd still like to add support for panning, so I'm going to leave this open. |
Brilliant, thanks Grant!
|
I have created a simple text box that displays perfectly in Android Studio, however when I turn the text box into a scroll group the text box does not display anymore after hot reload.
In XD I receive the following error:
1 Error:
[Scroll Group 1] Unable to create export node from none named 'ScrollableGroup'.
The text was updated successfully, but these errors were encountered: