fix: showing of UncategorizedNotification
#571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7d12afd in 31 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/components/UncategorizedNotification.vue:33
- Draft comment:
The change from milliseconds to seconds for the comparison inisVisiblemethod is correct based on the context provided. This ensures that the notification visibility logic is consistent with the unit of measurement fortotal. - Reason this comment was not posted::
Confidence changes required:0%
The PR description mentions thatthis.totalis in seconds, not milliseconds, and the change in the code reflects this understanding by changing the comparison from60 * 60 * 1000to60 * 60. This change seems correct based on the description and the context provided in the code. Thetotalis derived fromuncategorizedDuration[1], which is likely in seconds as no conversion to milliseconds is evident in the code. The change ensures that the comparison is consistent with the unit of measurement fortotal.
Workflow ID: wflow_UWo4i7QKm2EvLJvS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 11 days left in your free trial, upgrade for $20/seat/month or contact us.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 25.60% 25.60%
=======================================
Files 27 27
Lines 1613 1613
Branches 273 273
=======================================
Hits 413 413
Misses 1174 1174
Partials 26 26 ☔ View full report in Codecov by Sentry. |
|
Nice find! 🏅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.totalis in seconds, not milliseconds