Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSE ID field shouldn't be used #172

Closed
kevinbader opened this issue Feb 24, 2019 · 1 comment
Closed

SSE ID field shouldn't be used #172

kevinbader opened this issue Feb 24, 2019 · 1 comment
Assignees
@kevinbader
Labels
bug good first issue

Comments

@kevinbader
Copy link
Contributor

Afaik the SSE id: ... line is only used for setting the lastEventId property on the client. Since currently RIG cannot support lastEventId, I think the ID field shouldn't be set at all to prevent confusion. This issue is about investigating whether it makes sense or not to keep the ID field, and removing it in case there's no use for it.
@kevinbader kevinbader added the bug label Feb 24, 2019
@kevinbader kevinbader self-assigned this Feb 24, 2019
@kevinbader
Copy link
Contributor Author

closed in favor of #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinbader kevinbader

Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinbader