bumps sphinx and myst-parser pinned versions to play nicely with Python 3.13 #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1815 +/- ##
==========================================
- Coverage 84.11% 81.63% -2.49%
==========================================
Files 198 176 -22
Lines 22241 12683 -9558
Branches 4687 2784 -1903
==========================================
- Hits 18709 10354 -8355
+ Misses 2610 1783 -827
+ Partials 922 546 -376
Flags with carried forward coverage won't be shown. Click here to find out more. see 123 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
If there is an associated issue, link it in the form:
Fixes #1807
Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.
Summarize your change.
Building docs on Python 3.13 fails due to Sphinx pinned version requiring imghdr which is deprecated in newer python versions as of 3.13 (deprecated but available in 3.12).
Bumping pinned versions
sphinx==7.3.7andmyst-parser==3.0.1allows building docs on Python 3.13.Add a list of changes, and note any that might need special attention during review.
Reference associated tests.
If no new tests are introduced as part of this PR, note the tests that are providing coverage.