Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sphinx pinned version to get newer python support and remove imghdr requirement #1807

Open
vade opened this issue Oct 29, 2024 · 1 comment · May be fixed by #1815
Open

Update Sphinx pinned version to get newer python support and remove imghdr requirement #1807

vade opened this issue Oct 29, 2024 · 1 comment · May be fixed by #1815
Labels
build issues building OTIO documentation good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue.

Comments

@vade
Copy link
Contributor

vade commented Oct 29, 2024

Required:

[ x] I believe this isn't a duplicate topic
[ x] This report is not related to an adapter

Select One:

[ x] Build problem
[ ] Incorrect Functionality or bug
[ ] New feature or functionality

Description

Building docs on Python 3.13 fails due to Sphinx pinned version requiring imghdr which is deprecated in newer python versions as of 3.13 (deprecated but available in 3.12)

Environment

macOS 14.6 running conda env python 3.13

Reproduction Steps

cd docs
pip install -r requirements
make html

fixed by installing python 3.12.
@reinecke reinecke added good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue. build issues building OTIO documentation labels Nov 7, 2024
@benjamin-white-233
Copy link

Hello! In my local fork I have pinned sphinx==7.3.7 and myst-parser==3.0.1. The docs are now building successfully from Python 3.13. Will submit a PR shortly!

@benjamin-white-233 benjamin-white-233 linked a pull request Nov 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build issues building OTIO documentation good first issue If you're looking for a way to contribute, but not sure where to start. This is a good first issue.
Projects
None yet
Milestone
No milestone
3 participants
@vade @reinecke @benjamin-white-233