Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1 - Running The Scripts #14

Merged
merged 6 commits into from
May 27, 2024
Merged

Feature/1 - Running The Scripts #14

merged 6 commits into from
May 27, 2024

Conversation

MobiTikula
Copy link
Collaborator

@MobiTikula MobiTikula commented May 22, 2024 •
edited

This initial PR is for setting the environment correctly and to have option to run the scripts locally.

  • README.md now includes local execution details.
  • Improved environment cleanup logic in clean_env_before_mining method.

@MobiTikula MobiTikula self-assigned this May 22, 2024
miroslavpojer
miroslavpojer reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see updated README.md file describing *.sh file how to run scripts locally.

dist/controller.py Outdated Show resolved Hide resolved
@MobiTikula MobiTikula changed the title Feature/1 Running The Scripts Feature/1 - Running The Scripts May 23, 2024
@MobiTikula
Copy link
Collaborator Author

MobiTikula commented May 23, 2024 •
edited

Release Notes:

  • README.md includes local script execution in step by step description
  • controller.py updated, so it runs all the scripts from one place
  • clean_env_before_mining.py fully migrated to new technology

@miroslavpojer
Copy link
Collaborator

miroslavpojer commented May 24, 2024 •
edited

The import from clean_env_before_mining import clean_environment is no longer needed in controller.py.

miroslavpojer
miroslavpojer previously approved these changes May 24, 2024
View reviewed changes
src/clean_env_before_mining.py Show resolved Hide resolved
@MobiTikula MobiTikula merged commit ee17607 into master May 27, 2024
3 checks passed
@MobiTikula MobiTikula deleted the feature/1_Running_the_scripts branch May 27, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

Assignees

@MobiTikula MobiTikula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MobiTikula @miroslavpojer