Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tools #16

Open
odaymusic opened this issue Feb 3, 2020 · 18 comments
Open

new tools #16

odaymusic opened this issue Feb 3, 2020 · 18 comments

Comments

@odaymusic
Copy link

Is it possible to develop the program to support eastern Arab voices ... where there are signs and keys for oriental music, if added, it will be something special

@AaronDavidNewman
Copy link
Owner

Is this what you mean? https://github.com/0xfe/vexflow/wiki/Microtonal-Support
Vexflow is the engraving and font logic behind smoosic, so these are all planned. I admit to not knowing much about non-European music notation, but it is something I'd like to pursue.

@AaronDavidNewman
Copy link
Owner

@odaymusic I have added support to smoosic, for those 'microtone' accidentals that are supported by vex. I'm sure I got the playback wrong for some of them. I'd like to hear what you think.

@odaymusic
Copy link
Author

Is this what you mean? https://github.com/0xfe/vexflow/wiki/Microtonal-Support
Vexflow is the engraving and font logic behind smoosic, so these are all planned. I admit to not knowing much about non-European music notation, but it is something I'd like to pursue.

ys this i see new update for oriantal Symbols good work <3

@odaymusic
Copy link
Author

Symbols are placed and you try this is very good, but you should also be affected by signs and symbols, since after adding the symbol, the sound has not changed .. For example, from c to D is equal to one if from C to C# text and here we hear the difference in sound The eastern mark is Half of if soaked from the frequency of the sound in half to become from C to C# quarter of a distance and not half in form and hearing

@AaronDavidNewman
Copy link
Owner

I think you are talking about the way the symbols sound. There were some bugs. I have an example in the file menu now that shows the tones and what they do. If you look in noteModifiers.js, the function 'SmoMicrotone.pitchCoeff' has the formula that I use, in 1/2 steps (so 0.5 on C is 1/2 between C and C#). Some of these were just a guess, and also I don't know how to do 'comma'. If you're interested, feel free to modify that and I'll pull it.
Right now I'm treating them more like articulations than accidentals, they don't persist in the measure. I'm not sure if that is correct, either.

@odaymusic
Copy link
Author

odaymusic commented May 20, 2020 via email

@AaronDavidNewman
Copy link
Owner

AaronDavidNewman commented May 21, 2020

Edit: I see what you mean about the error box. That's a bug! You should not be able to delete the only measure.

It depends on what you mean by delete. To toggle note to rest, the key is 'r'. Delete key deletes an entire measure. If you want to reduce the number of beats in a measure, you can use the measure dialog.

@odaymusic
Copy link
Author

odaymusic commented May 21, 2020 via email

@odaymusic
Copy link
Author

odaymusic commented May 21, 2020 via email

@AaronDavidNewman
Copy link
Owner

I fixed the bug with deleting measures, and the 'ghost' tones that appeared.

The duration of notes in a measure always matches the time signature. You can reduce the number of notes in the measure by reducing the beats in a time signature, down to a single 1/8 note, if you want. You can increase the duration of notes, etc. But there always has to be at least one measure and measures are never 'empty'. I will probably add ability to 'hide' notes at some time, but right now I am focused on formatting.

@odaymusic
Copy link
Author

odaymusic commented May 21, 2020 via email

@AaronDavidNewman
Copy link
Owner

What you have been doing is great. I'd welcome any help with the application, including donations of code, testing, documentation etc. I'm not looking for money donations at this point, just community participation. Also, the javascript part of Smoosic will always be free and open-source, so there's nothing to 'market' at this point.

@odaymusic
Copy link
Author

odaymusic commented May 25, 2020 via email

@AaronDavidNewman
Copy link
Owner

I like this a lot. You are clearly a better graphic artist than I am. Let me think for a bit on how to get the application fully multi-lingual. It should be possible to support multiple languages (including R-L) with the same css using the flex model, and just changing the html direction attribute. right now I am using a mix of absolute positioning and flex and it is a little sloppy.

You might want to use this for the vexflow link. The link you used will come and go - it is for my contributions to vexflow. This one is stable for smoosic: https://aarondavidnewman.github.io/vexflow_smoosic/releases/vexflow-debug.js

It would be nice to have the piano scroll-able (right to left) for the full piano range.

@AaronDavidNewman
Copy link
Owner

AaronDavidNewman commented Jun 7, 2020

The latest version of Smoosic allows switching between translations, EN to AR. There is a language_ar.js file. If you are so inspired, you could create the translations in that file and submit as a pull request. Anything with 'label' or 'text' is translated text. Anything else is an identifier so you can tell the context. I'll post some more info later when I have time.
Edit: I forgot to mention, the text direction is now automatic and part of the css.

@AaronDavidNewman
Copy link
Owner

Hi @odaymusic , I have created some translation tools if you are interested in contributing any more Arabic translations to Smoosic. I pulled what I could from 'nota', but as I don't speak or read Arabic, I am hesitant to do too much.

Link to translation tool:
https://aarondavidnewman.github.io/Smoosic/release/html/smoosic.html?translate=ar

Link to Wiki for instructions.
https://github.com/AaronDavidNewman/Smoosic/wiki/Internationalizing-Smoosic

Also if 'nota' has a location on GitHub, I'd like to stay up with any changes.

I will be closing this issue in a couple of weeks, since it covers a couple of issues that have been fixed. Feel free to open a ticket if you have more suggestions, or a pull request with any translations or changes.

@odaymusic
Copy link
Author

odaymusic commented Sep 29, 2020 via email

@AaronDavidNewman
Copy link
Owner

Welcome back. I'm not sure if I understand about 'add or delete tones '. Do you want to be able to add notes to a measure, beyond the time signature (like a cadenza)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants