Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup instructions suggest use of deprecated wagtail middleware #283

Open
banagale opened this issue Aug 6, 2023 · 0 comments
Open

Setup instructions suggest use of deprecated wagtail middleware #283

banagale opened this issue Aug 6, 2023 · 0 comments

Comments

@banagale
Copy link

banagale commented Aug 6, 2023

The setup docs ask for the following to be added to settings.py

MIDDLEWARE_CLASSES = (
    ...
    'wagtail.core.middleware.SiteMiddleware',
    'wagtail.contrib.redirects.middleware.RedirectMiddleware',
)

The first middleware recommended is deprecated. I suspect this is just outdated docs, because the replacement way to get at Site, from wagtail.core.models import Site is used a few times in the package.

Also, should this be updated to suggest the redirect middleware be added to MIDDLEWARE? Use of MIDDLEWARE_CLASSES conflicts with django debug toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant