Unify environment variable handling

[nbars]

Is your feature request related to a problem? Please describe.
Grepping through the code-base reveals many locations using getenv with hardcoded constants, even though there seems to be an interface (afl_env_vars_t) to unify the handling of environment variables. This makes it hard to keep track of which tool (afl-fuzz, afl-cmin, ...) implements which functionality.

Describe the solution you'd like
Unify environment variable handling by using afl_env_vars_t and related functions. This will require, besides other things, decoupling of read_afl_environment() from afl_state_t since afl_state_t is not used by all tools as far as I can tell.

Best,
Nils

[vanhauser-thc]

a few vars are required before parsing the environment, but yes, in general that could be done and would be more clean.
but it is also effort. if you do not like it the way it is - please supply a PR.

[Kundanagrawalofficial]

i think we can use this code
#include <stdlib.h>
#include "afl_env_vars.h"

afl_env_vars_t env_vars;

void init_env_vars() {
afl_init_env_vars(&env_vars);
}

void read_environment() {
afl_read_env_vars(env_vars, "ENV_VAR_NAME", &env_var_value);
/* use env_var_value */
}

void cleanup_env_vars() {
afl_cleanup_env_vars(&env_vars);
}

[nbars]

I really dont have time for that, but I guess pull requests are more than welcome :)

[sheftechdad]

hey,i really want to work on this issue

[KhushV25]

Hey can I work on this?

[vanhauser-thc]

Hey can I work on this?

sure

[AlishRani]

/assign