Bugs in misc/db/PostgreSQL/series/PG_update_43_44*.sql

[EHJ-52n]

1. Missing whitespace after constraint name in line 103 in PG_update_43_44.sql:

   alter table public.featureparameter add constraint FK_4ps6yv41rwnbu3q0let2v7foreign key (featureOfInterestId) references public.featureofinterest;

   Should be

   alter table public.featureparameter add constraint FK_4ps6yv41rwnbu3q0let2v7 foreign key (featureOfInterestId) references public.featureofinterest;

2. In addtion, please replace the cyrptic constraint names:
   • FK_4ps6yv41rwnbu3q0let2v7
   • FK_3v5iovcndi9w0hgh827hcvivw
   • FK_g0f0mpuxn3co65uwud4pwxh4q
   • FK_m4nuof4x6w253biuu1r6ttnqc
3. Add the missing ; to line 123 in PG_update_43_44.sql:

   create sequence public.relatedObservationId_seq

   Should be

   create sequence public.relatedObservationId_seq;

4. Add missing alias definition for ser to lline33 in PG_update_43_44_series_table.sql:

   update public.series ser set offeringId = (Select distinct off.offeringId from public.offering off, public.observation o, public.observationhasoffering ohof where ser.seriesid = o.seriesid AND o.observationid = ohof.observationid AND ohof.offeringId = off.offeringId);

   Should be

   update public.series ser set offeringId = (Select distinct off.offeringId from public.offering off, public.observation o, public.observationhasoffering ohof, public.series ser where ser.seriesid = o.seriesid AND o.observationid = ohof.observationid AND ohof.offeringId = off.offeringId);

[ghost]

I've been scripting the update of some 4.3.x databases to 4.4.0, using the PostgreSQL .sql files from the develop branch. If I include all the comments above except for the very last one, AFAIK it works OK, all the clients appear fine.

if I include the last comment, and add the ser alias definition I get the following error when converting:

ERROR:  more than one row returned by a subquery used as an expression
STATEMENT:  update public.series ser set offeringId = (Select distinct off.offeringId from public.offering off, public.observation o, public.observationhasoffering ohof, public.series ser where ser.seriesid = o.seriesid AND o.observationid = ohof.observationid AND ohof.offeringId = off.offeringId);

[himanshusharma27]

I want to work on this issue . Please assign me this issue .