Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-down Tanks Redux - Kenney #6542

Open
Kruger77 opened this issue Apr 25, 2024 · 8 comments
Open

Top-down Tanks Redux - Kenney #6542

Kruger77 opened this issue Apr 25, 2024 · 8 comments
Labels
📦 Asset Store submission A pack of assets for the asset store

Comments

@Kruger77
Copy link

Description

Hello guys, I have just finished packaging this asset pack by Kenney I hope it can be useful for you

@Kruger77 Kruger77 added the 📦 Asset Store submission A pack of assets for the asset store label Apr 25, 2024
@D8H
Copy link
Collaborator

D8H commented May 4, 2024

Thank you for submitting a packaging.

Please also attach the project you used to generate the GDO file. It will ease review.

@Kruger77
Copy link
Author

Kruger77 commented May 5, 2024

Of course, it's not an empty project, but I've renamed the scene to TanksAssetPack and there's only the folder with the assets inside. There's also the scene of that other asset pack that I sent after this
assets.zip

@D8H
Copy link
Collaborator

D8H commented May 11, 2024

Thank you for submitting a pack.

The asset store doesn't handle custom collision masks nor origin. An automatic collision mask is evaluated on the 1st frame of the 1st animation.

It means that:

  • Tank barrels and bullets collision masks will be off on other animations so they should be 1 Sprite object for each kind.
  • Explosion animations won't be centered correctly so the frames need to be extended to 128x128 pixels.

Point of views are not states as users won't toggle between them. Barrels and creates should be independent sprites.
A color variation is usually not a state either. Fences and barricades should be independent sprites too.

Sprite names should almost never be plural.

@Kruger77
Copy link
Author

Ok, thanks for the feedback, I'll work on these things and re send the pack

@Kruger77
Copy link
Author

Thank you for submitting a pack.

The asset store doesn't handle custom collision masks nor origin. An automatic collision mask is evaluated on the 1st frame of the 1st animation.

It means that:

  • Tank barrels and bullets collision masks will be off on other animations so they should be 1 Sprite object for each kind.

  • Explosion animations won't be centered correctly so the frames need to be extended to 128x128 pixels.

Point of views are not states as users won't toggle between them. Barrels and creates should be independent sprites. A color variation is usually not a state either. Fences and barricades should be independent sprites too.

Sprite names should almost never be plural.

Re reading everything again and watching the asset pack at this point only the explosion will go in the GDO while the other stuff will be in the zip file as a single sprites

@Kruger77
Copy link
Author

Asset Store - Top-down.Tanks.Redux.-.Kenney.zip
now should be good

@D8H
Copy link
Collaborator

D8H commented May 19, 2024

The project resources are broken.

Please can you attach an archive with:

  • a project folder containing the 2 explosions (only this if possible)
  • a folder with the other PNG (only the files that must be included as still sprites and excluding the version without underline as they won't be included in the pack)

@Kruger77
Copy link
Author

The project resources are broken.

Please can you attach an archive with:

  • a project folder containing the 2 explosions (only this if possible)
  • a folder with the other PNG (only the files that must be included as still sprites and excluding the version without underline as they won't be included in the pack)

Maybe because I changed the name of the file? I'll send you another zip file next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Asset Store submission A pack of assets for the asset store
Projects
None yet
Development

No branches or pull requests

2 participants