Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting to toggle native uploads from discord #1965

Open
yousefmansy1 opened this issue Feb 11, 2023 · 2 comments · May be fixed by #1977
Open

Setting to toggle native uploads from discord #1965

yousefmansy1 opened this issue Feb 11, 2023 · 2 comments · May be fixed by #1977
Labels
discord enhancement New feature or request

Comments

@yousefmansy1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When bridging discord to WhatsApp/Telegram/etc any images come across as a URL.
Though the URL does allow for others to access the image sent, it does not embed properly (or in most cases not at all).

The Docs do say

Attachment / files handling
The logic is: Public links > Native file upload > External mediaserver > Private links

But giving users the choice would be beneficial, and would allow for images to show properly natively on platforms that do not embed image URLs.

Describe the solution you'd like
A setting within a discord config (perhaps UseNaitiveUploads?) to enable native uploads from discord to other platforms.

Describe alternatives you've considered
As of now I do not know of an alterative that would fulfil this

Additional context
None.
@yousefmansy1 yousefmansy1 added the enhancement New feature or request label Feb 11, 2023
@yousefmansy1 yousefmansy1 changed the title Setting for native uploads from discord. Setting to toggle native uploads from discord Feb 11, 2023
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Feb 19, 2023
@yousefmansy1
Add option for using a naitive upload when relaying from discord
95e86c5 
Resolves 42wim#1965
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Feb 19, 2023
@yousefmansy1
Add option for using a naitive upload when relaying from discord
0bbdbad 
Resolves 42wim#1965
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Feb 19, 2023
@yousefmansy1
Add option for using a naitive upload when relaying from discord
e4a672c 
Resolves 42wim#1965
@yousefmansy1 yousefmansy1 linked a pull request Feb 19, 2023 that will close this issue
Open
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Feb 19, 2023
@yousefmansy1
Add option for using a naitive upload when relaying from discord
8a46599 
Resolves 42wim#1965
@qaisjp
Copy link
Collaborator

qaisjp commented Feb 22, 2023

instead of having UseNativeUploads, and then in the future maybe wanting UseExternalMediaServer; what do you think of an array of preferences?

Don't look too closely at the actual string values inside the array but the idea is that the default of UploadPriorities is ["public_links", "native_upload", "media_server", "private_links"]; and people could change the order to their preference.

@yousefmansy1
Copy link
Contributor Author

Hmm that's actually a good idea.
Although that seems like it'd be quite the refactor right now to implement lol.
Can we kick that can down the road?

Probably create a issue to track gauge interest, then prioritize from there.

yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Feb 22, 2023
@yousefmansy1
Add option for using a naitive upload when relaying from discord
7561fd3 
Resolves 42wim#1965
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Feb 24, 2023
@yousefmansy1
Add option for using a naitive upload when relaying from discord
014c008 
Resolves 42wim#1965
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Mar 14, 2023
@yousefmansy1
Add option for using a naitive upload when relaying from discord
f2bee25 
Resolves 42wim#1965
@42wim 42wim added the discord label Mar 14, 2023
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Mar 15, 2023
@yousefmansy1
Use native upload when relaying from discord.
3ffd96a 
Resolves 42wim#1965
yousefmansy1 added a commit to yousefmansy1/matterbridge that referenced this issue Mar 15, 2023
@yousefmansy1
Use native upload when relaying from discord.
d9b016f 
Resolves 42wim#1965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discord enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use native upload when relaying from discord yousefmansy1/matterbridge
3 participants
@qaisjp @42wim @yousefmansy1