Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate flash.sh script into image #80

Closed
4 tasks
macpijan opened this issue Nov 4, 2024 · 7 comments · Fixed by #83
Closed
4 tasks

Integrate flash.sh script into image #80

macpijan opened this issue Nov 4, 2024 · 7 comments · Fixed by #83
Assignees

Comments

@macpijan
Copy link
Member

macpijan commented Nov 4, 2024

Integrate script from: 3mdeb/RteCtrl#22 into v0.8.X release

  • Add recipe for flash.sh script to meta-rte and integrate it into image by default
  • Remove this script from RteCtrl
  • Scan Dasharo documentation references to flash.sh and remove them. Or leave a note that this flash.sh script is integrated on RTE OS v0.8.x or higher if needed, depending on the found case.
  • Extend script with additional parameters/env variables, such as:
    • ability to select 1.8V vs 3.3V (currently it is hardcoded to 3.3V)
    • ability to provide some extra parameters to flashrom command (such as: -ifd -i fd -i me -i bios)
@macpijan
Copy link
Member Author

macpijan commented Nov 5, 2024

This is designed to have some working solution in a short term.

As suggested in 3mdeb/RteCtrl#22 (comment) already, this flash.sh script is not a perfect approach, and we already have something better with osfv_cli.

This can take a bit more time to discuss and implement, that is why we have a separate ticket for it here: #82

@artur-rs artur-rs assigned DaniilKl and unassigned artur-rs and EduKav1813 Nov 7, 2024
DaniilKl added a commit that referenced this issue Nov 7, 2024
Add flash.sh script from 3mdeb/RteCtrl#22.
For more inf. check #80.

Signed-off-by: Daniil Klimuk <[email protected]>
DaniilKl added a commit to Dasharo/docs that referenced this issue Nov 7, 2024
For more inf. check 3mdeb/meta-rte#80.

Signed-off-by: Daniil Klimuk <[email protected]>
@DaniilKl DaniilKl linked a pull request Nov 7, 2024 that will close this issue
@macpijan
Copy link
Member Author

macpijan commented Nov 7, 2024

@wessel-novacustom

If you'd like to test the updated version of the script from: https://github.com/3mdeb/meta-rte/pull/83/files

The file can be downloaded here: https://raw.githubusercontent.com/3mdeb/meta-rte/c4c0f2b6c947061defa1b83bd585745ec0ecadb6/recipes-go/3mdeb-rtectrl/3mdeb-rtectrl/flash.sh

DaniilKl added a commit to Dasharo/docs that referenced this issue Nov 8, 2024
For more inf. check 3mdeb/meta-rte#80.

Signed-off-by: Daniil Klimuk <[email protected]>
@macpijan
Copy link
Member Author

@wessel-novacustom did you have a chance to test this?

@wessel-novacustom
Copy link

@wessel-novacustom did you have a chance to test this?

Not yet, I will do so on Saturday.

@wessel-novacustom
Copy link

@macpijan

flashrom -p "$FLASHROM_PROGRAMMER" "$FLASHROM_PARAMS"

Is wrong.

It results in:

root@rte:~# ./flash.sh -V 3.3V probe
Setting SPI VCC to 3.3V
SPI lines ON
SPI Vcc ON
Probing ...
flashrom 1.4.0 on Linux 6.6.28 (armv7l)
flashrom is free software, get the source code at https://flashrom.org

Error: Extra parameter found.
Please run "flashrom --help" for usage info.
SPI Vcc OFF
SPI lines OFF


The fix would be:

flashrom -p "$FLASHROM_PROGRAMMER" $FLASHROM_PARAMS

So without the double quotes for the flashrom params.


I just made that change and tried:

root@rte:~# ./flash.sh -V 3.3V probe --flashrom-params "-o output.txt"

And that generated the output.txt file correctly, meaning that the flashrom params are still working, while now also without flashrom params.

@macpijan
Copy link
Member Author

@DaniilKl

@DaniilKl
Copy link
Contributor

Fixed, more inf. in linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants