Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass cas api cpus explicitly to the process #199

Merged

Conversation

smrz2001
Copy link
Collaborator

@smrz2001 smrz2001 commented Jul 9, 2024

The code for CAS API clustering (launching as many NodeJS processes as their are CPUs available) is not working in Keramik. This is causing the host's CPUs to be used, which launches 32 processes and causes the container to OOM.

This PR converts the CAS resource limits to an equivalent number of CPUs with a minimum of 1, and passes this number in to the container explicitly.

Copy link

linear bot commented Jul 9, 2024

@smrz2001 smrz2001 self-assigned this Jul 9, 2024
@smrz2001 smrz2001 force-pushed the feature/aes-204-pass-cas-api-cpus-explicitly-in-keramik branch from 9691ce3 to 5161561 Compare July 9, 2024 20:51
Copy link
Contributor

@3benbox 3benbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smrz2001 smrz2001 added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 88f2507 Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants