Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ceramic http client and fix recon sync test #189

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

dav1do
Copy link
Contributor

@dav1do dav1do commented Jun 24, 2024

Updates the ceramic-http-client-rs dependency and uses the new event format from rust ceramic. This allows the recon-event-sync scenario to work without failing due "unexpected fields" when the API roundtrips the payload to make sure it is as expected.

@dav1do dav1do requested review from samika98 and smrz2001 June 24, 2024 19:03
Copy link
Collaborator

@smrz2001 smrz2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dav1do dav1do added this pull request to the merge queue Jun 27, 2024
Copy link
Contributor

@samika98 samika98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good just a question about removing an await

runner/src/scenario/ceramic/model_instance.rs Show resolved Hide resolved
Merged via the queue into main with commit beded49 Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants