Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements - Suggestions for configurable inputs. #289

Open
projectuwb opened this issue May 23, 2022 · 3 comments
Open

Enhancements - Suggestions for configurable inputs. #289

projectuwb opened this issue May 23, 2022 · 3 comments
Assignees
Labels
App 📱 User-facing issues enhancement New feature or request

Comments

@projectuwb
Copy link

  1. When scheduling a claim, it seems that a default 20 min timer activates from the time the schedule claim tx is approved. Wondering if this should be configurable?
  2. When creating the quest, there was no way to input how to limit x tokens per claim. Again would assume this would be good to be able to configure.
@projectuwb projectuwb added the enhancement New feature or request label May 23, 2022
@Corantin
Copy link
Collaborator

Corantin commented Jun 2, 2022

Right now (for MVP) the delay will be 7 days in gnosis network. However, this is a minimum value and the UI could propose to add more time but I would like to enforce it from where we create the quest but the only time it is submitted to the contract is at the moment the player claim. The enforcement of having a config for the Quest requires modifying some solidity contracts that we don't have ownership of (GovernQueue.sol schedule function if you have some knowledge on solidity and want to have a look at it). This will be something we will investigate in the future tho because it would be great if its configurable because 7 days doesn't fit the needs for everyone

@Corantin
Copy link
Collaborator

Corantin commented Jun 2, 2022

That was for point 1, the point 2 is more of a design decision, we wanted a Quest to be driven by the description, so if the creator wants to only allow like 150HNY max for a claim, having it in the description would be enough and if a Player claims more, the claim will likely be challenged by either of the Creator or any other person. The player does not have any interest in doing that because when he claims, he has to deposit collateral and if his claim is successfully challenged, the Player will then lose his deposit (the deposit is sent to the challenger)

@Corantin Corantin added the App 📱 User-facing issues label Jun 8, 2022
@Corantin
Copy link
Collaborator

DOD :

  • Add a time input in the create-quest-modal for extra validation delay
  • Pass the value in QuestModel and use it in image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App 📱 User-facing issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants